Add "atPosition:" variations to UICollectionView waitForCellAtIndexPath methods

[gaperlinski]

Allows the consumers to specify custom UICollectionViewScrollPosition of the cell they want to scroll to. UICollectionViewScrollPositionCenteredHorizontally | UICollectionViewScrollPositionCenteredVertically remains to the default value.

[justinseanmartin]

Thanks for the contribution!

Please add a test to the test suite to ensure that it is behaving as expected and I'll happily merge this change. You could maybe check the returned cell's frame relative to the window?

This will help to ensure that we don't regress the behavior and Apple doesn't change it behind the scenes.

[justinseanmartin]

@gaperlinski - Any chance that you'd have time to add a test showing that this works and ensuring that we (or Apple) don't break the functionality in the future? Sad to see this go to waste. Thanks!

[gaperlinski]

@justinseanmartin I'm back from the dead. Sorry! Will try to cook something up over the weekend.

[harleyjcooper]

If you need any assistance, please let me know. This will help me out with a bug I'm facing. I'll be around to assist through next Wednesday if need be.

[harleyjcooper]

Would something like this do the trick?

diff --git a/KIF Tests/CollectionViewTests.m b/KIF Tests/CollectionViewTests.m
index 47102d1..c5eb214 100644
--- a/KIF Tests/CollectionViewTests.m   
+++ b/KIF Tests/CollectionViewTests.m   
@@ -59,6 +59,27 @@
 }
 
 
+- (void)testTappingLastAndFirstRowAtPositionWithAccessiblityIdentifier
+{
+    UICollectionViewCell *lastCell = [tester waitForCellAtIndexPath:[NSIndexPath indexPathForRow:-1 inSection:-1] inCollectionViewWithAccessibilityIdentifier:@"CollectionView Tests CollectionView" atPosition:UICollectionViewScrollPositionBottom];
+    CGPoint lastPosition = [lastCell.superview convertPoint:lastCell.frame.origin toView:nil];
+    XCTAssertEqual(lastCell.frame.origin.x, lastPosition.x);
+    UICollectionViewCell *firstCell = [tester waitForCellAtIndexPath:[NSIndexPath indexPathForRow:0 inSection:0] inCollectionViewWithAccessibilityIdentifier:@"CollectionView Tests CollectionView" atPosition:UICollectionViewScrollPositionTop];
+    CGPoint firstPosition = [firstCell.superview convertPoint:firstCell.frame.origin toView:nil];
+    XCTAssertEqual(0, firstPosition.x);
+}
+
+- (void)testTappingLastAndFirstRowAtPositionWithView
+{
+    UICollectionView *collectionView = (UICollectionView *)[[viewTester usingIdentifier:@"CollectionView Tests CollectionView"] waitForView];
+    UICollectionViewCell *lastCell = [tester waitForCellAtIndexPath:[NSIndexPath indexPathForRow:-1 inSection:-1] inCollectionView:collectionView atPosition:UICollectionViewScrollPositionBottom];
+    CGPoint lastPosition = [lastCell.superview convertPoint:lastCell.frame.origin toView:nil];
+    XCTAssertEqual(lastCell.frame.origin.x, lastPosition.x);
+    UICollectionViewCell *firstCell = [tester waitForCellAtIndexPath:[NSIndexPath indexPathForRow:0 inSection:0] inCollectionView:collectionView atPosition:UICollectionViewScrollPositionTop];
+    CGPoint firstPosition = [firstCell.superview convertPoint:firstCell.frame.origin toView:nil];
+    XCTAssertEqual(0, firstPosition.x);
+}
+
 - (void)testOutOfBounds
 {
     KIFExpectFailure([[tester usingTimeout:1] tapItemAtIndexPath:[NSIndexPath indexPathForItem:0 inSection:99] inCollectionViewWithAccessibilityIdentifier:@"CollectionView Tests CollectionView"]);```

[harleyjcooper]

@gaperlinski I can't really make any changes so I opened up #1109

[gaperlinski]

@harleyjcooper, sorry for leaving you hanging. For some reason, I didn't get any notifications about these messages. It LGMT but it looks like Travis CI is not loving the iPad Pro simulator...

[justinseanmartin]

Going to close this in favor of #1109. Feel free to reopen if you take this back over from @harleyjcooper .