Add "atPosition:" variations to UICollectionView waitForCellAtIndexPa… #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @harleyjcooper ! I've been pretty lousy with finding find to add the test. Btw, I'm wondering why tests fail on iPad simulator. Doesn't seem to be connected to this change. |
gaperlinski
reviewed
May 31, 2019
KIF Tests/CollectionViewTests.m
Outdated
| @@ -59,6 +59,27 @@ - (void)testTappingLastItemAndSectionWithoutAnimation | |||
| } | |||
|
|
|||
|
|
|||
| - (void)testTappingLastAndFirstRowAtPositionWithAccessiblityIdentifier | |||
There was a problem hiding this comment.
I would rename this and the other test to testScrolling since you're not really tapping anything
gaperlinski
reviewed
May 31, 2019
KIF Tests/CollectionViewTests.m
Outdated
| { | ||
| UICollectionViewCell *lastCell = [tester waitForCellAtIndexPath:[NSIndexPath indexPathForRow:-1 inSection:-1] inCollectionViewWithAccessibilityIdentifier:@"CollectionView Tests CollectionView" atPosition:UICollectionViewScrollPositionBottom]; | ||
| CGPoint lastPosition = [lastCell.superview convertPoint:lastCell.frame.origin toView:nil]; | ||
| XCTAssertEqual(lastCell.frame.origin.x, lastPosition.x); |
There was a problem hiding this comment.
Is this a vertically scrolling collection view? If so, shouldn't you be checking here the y position (whether it aligns to the top/bottom of the collection view bounds)?
There was a problem hiding this comment.
OK I'm comparing the y now. I'm a bit fuzzy on UIView coordinate conversion, but this seems to work.
|
This all looks totally reasonable to me. Thanks Harley! |
harleyjcooper
deleted the
harley/gaperlinski/collectionViewScrollAtPosition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over from @gaperlinski for #1061 :