Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-add accepts package names with mismatching hyphen/underscore without conversion #51

Closed
crumblingstatue opened this issue Oct 23, 2015 · 2 comments
Closed

cargo-add accepts package names with mismatching hyphen/underscore without conversion #51

crumblingstatue opened this issue Oct 23, 2015 · 2 comments
Labels
cargo-add easy enhancement help wanted

Comments

@crumblingstatue
Copy link

Examples:

error_def

$ cargo add error-def
$ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
no matching package named `error-def` found (required by `undered`)

quick-error

$ cargo add quick_error
$ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
no matching package named `quick_error` found (required by `undered`)
@killercup
Copy link
Owner

Yes. In some RFC, Cargo's name conversions are described pretty good. We should probably support those (maybe checking a few variations on error).

@killercup killercup added the easy label Feb 7, 2016
caulagi pushed a commit to caulagi/cargo-edit that referenced this issue Mar 4, 2016
🐛 Return error if name in crates.io is different from the name that is
282ffb3 
being added [fixes killercup#51]
@caulagi caulagi mentioned this issue Mar 4, 2016
Closed
@killercup
Copy link
Owner

Fixed in #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cargo-add easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killercup @crumblingstatue