-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New year, new bugfixes #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Request only versions from server to save bandwith.
This way, we can actually differentiate between packages when adding more than one. This would've caught #92.
Maybe add some regression tests for adding multiple crates? |
@sebasgarcep there are two tests for adding multiple deps, that were just not working correctly before ( |
Nope that's it. |
Looks good to me. |
@homu r+
sinkuu <notifications@github.com> schrieb am Di. 3. Jan. 2017 um 01:23:
… Looks good to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABOXyHlFqsTXLpCCT8pGZs37smN0_C7ks5rOZTygaJpZM4LZDkA>
.
|
📌 Commit 93679c2 has been approved by |
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 3, 2017
…rcup New year, new bugfixes This is a rollup of #98 (which replaces #78), #99, and #100. @sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy. Just to make sure Github gets all the references: Fixes #52 Fixes #88 Fixes #92
This was referenced Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rollup of #98 (which replaces #78), #99, and #100.
@sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy.
Just to make sure Github gets all the references:
Fixes #52
Fixes #88
Fixes #92