Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New year, new bugfixes #101

Merged
merged 11 commits into from
Jan 3, 2017
Merged

New year, new bugfixes #101

merged 11 commits into from
Jan 3, 2017

Conversation

killercup
Copy link
Owner

This is a rollup of #98 (which replaces #78), #99, and #100.

@sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy.

Just to make sure Github gets all the references:

Fixes #52
Fixes #88
Fixes #92

@sebasgarcep
Copy link
Contributor

Maybe add some regression tests for adding multiple crates?

@killercup
Copy link
Owner Author

@sebasgarcep there are two tests for adding multiple deps, that were just not working correctly before (adds_multiple_dependencies and adds_multiple_dev_build_dependencies) but should do their job now. Or do you have other test cases in mind?

@sebasgarcep
Copy link
Contributor

Nope that's it.

@sinkuu
Copy link

sinkuu commented Jan 3, 2017

Looks good to me.

@killercup
Copy link
Owner Author

killercup commented Jan 3, 2017 via email

@homu
Copy link
Contributor

homu commented Jan 3, 2017

📌 Commit 93679c2 has been approved by killercup

@homu
Copy link
Contributor

homu commented Jan 3, 2017

⚡ Test exempted - status

@homu homu merged commit 93679c2 into master Jan 3, 2017
homu added a commit that referenced this pull request Jan 3, 2017
…rcup

New year, new bugfixes

This is a rollup of #98 (which replaces #78), #99, and #100.

@sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy.

Just to make sure Github gets all the references:

Fixes #52
Fixes #88
Fixes #92
@killercup killercup deleted the feature/new-year-new-bugfixes branch January 4, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants