Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does cargo-edit work on Windows? #55

Closed
killercup opened this issue Oct 24, 2015 · 19 comments
Closed

Does cargo-edit work on Windows? #55

killercup opened this issue Oct 24, 2015 · 19 comments

Comments

@killercup
Copy link
Owner

In #49 I tried to add AppVeyor (a CI for Windows) by copying the config used by regex. It didn't work for each target and I have no way to debug and fix this.

I'd be very happy if someone could have a look at this! 😃

@Seeker14491
Copy link

I've been trying to install cargo-edit on my Windows computer, but to no avail. The problem is building the curl dependency. I've ran into the following two issues:

alexcrichton/curl-rust#71
alexcrichton/curl-rust#81

@iopq
Copy link

iopq commented Dec 24, 2015

I tried to run it in mingw32, but that doesn't have make in it. Better Windows support would be nice.

@Seeker14491
Copy link

I've switched over to using the MSVC ABI version of Rust, and cargo-edit installs just fine.

@iopq
Copy link

iopq commented Dec 24, 2015

Oh, that's good. I do have the GNU ABI installed on this machine. Let me try on my laptop.

@Seeker14491
Copy link

I just got the latest nightly MSVC Rust, and now cargo-edit isn't installing anymore...

@killercup
Copy link
Owner Author

Great that you keep trying, @Seeker14491 :)

Would moving from curl to hyper help in your opinion? I guess it'll still need to build openssl, though.

@Seeker14491
Copy link

@killercup I think it would, since the problem is with building curl. I've never used curl or hyper though, so I'm not knowledgeable in this area.

@cnd
Copy link

cnd commented Jan 18, 2016

problematic to build curl-sys here either

@killercup
Copy link
Owner Author

Could you try building the branch from
#67 ? Thanks!
Heather notifications@github.com schrieb am Mo., 18. Jan. 2016 um 14:15:

problematic to build curl-sys here either


Reply to this email directly or view it on GitHub
#55 (comment)
.

@Seeker14491
Copy link

I've done some testing on Rust 1.7 stable running on Windows Server 2012 R2. I tested both the MSVC and GNU ABI versions of Rust.

MSVC: Running cargo install cargo-edit works.

GNU: Running cargo install cargo-edit fails with a curl-sys error.

I'm unable to test the hyper branch, as when I clone it and run cargo install --path ., I get the message multiple packages with binaries found: cargo-edit, cargo-list-empty-test-fix , cargo-list-test-fixture, cargo-rm-test-fixture. I'd like to know how to resolve this so I can test the hyper branch.

@Seeker14491
Copy link

I used the command cargo build --release instead to build the hyper branch, and these are the results:

MSVC: Fails with openssl error.

GNU: Works

@killercup
Copy link
Owner Author

Thanks for the research! What would you suggest we do? Also, can you build
cargo itself with the GNU tool chain? If that works we can maybe copy what
they do.

Brian Bowman notifications@github.com schrieb am Sa., 5. März 2016 um
06:59:

I used the command cargo build --release instead to build the hyper
branch, and these are the results:

MSVC: Fails with openssl error.

GNU: Works


Reply to this email directly or view it on GitHub
#55 (comment)
.

@Seeker14491
Copy link

@killercup I've tried building cargo on the GNU toolchain, and it errors with the same curl-sys error.

@LukasKalbertodt
Copy link

LukasKalbertodt commented May 7, 2016

I installed cargo-edit in my cygwin environment with the GNU toolchain. Building and installation worked out fine (after resolving curl-sys error), but executing cargo add something doesn't do anything (except for utilizing one core) and never returns. Can't figure out why. Any idea? Shall I open another issue for this problem?

@sebasgarcep
Copy link
Contributor

Would hyper resolve this issue?

@killercup
Copy link
Owner Author

@sebasgarcep see #55 (comment). This may be outdated, though, since most problem seem to stem from using OpenSSL. Looking at the dependencies for reqwest (a simple interface for hyper), it seems to depend on native-tls, which will use SChannel on Windows and Security.framework on macOS. As you can see, I've started porting this to hyper some time ago. I'm kind of weary switch to something new now (but I guess it would be reqwest), as I'm pretty sure, I'd end up rewriting the whole crate…

If you are interested: I'd make a crate to access crates.io data (with a futures-rs/tokio based interface ideally), switch to a style-preserving TOML writer (which AFAIKT does not exist yet), and switch to clap for CLI commands to get autocompletions for free. Oh, or I'd try to integrate add/rm into Cargo itself! :)

@sebasgarcep
Copy link
Contributor

Add/rm should come with cargo by default. :)

On a sidenote I own a crate (still in it's infancy) to fetch from the crates.io API. I'd love to discuss its direction. https://github.com/sebasgarcep/crates-api

@killercup
Copy link
Owner Author

killercup commented Jan 8, 2017 via email

@huettenhain
Copy link

Hey everyone, I just tried to install cargo-edit on my Windows machine and ran into the same problem building curl-sys v0.1.35. I would really love to get it to work, it looks fantastic, exactly what I have been craving - but I am reluctant to switch to MSVC. What is the current status of this issue?

bors bot added a commit that referenced this issue Jul 4, 2017
135: Add Appveyor Config for Windows CI r=bjgill

Reprise of #49 - it seems to work again now ([![Build status](https://ci.appveyor.com/api/projects/status/rba5ffptnj78o4xm?svg=true)](https://ci.appveyor.com/project/bjgill/cargo-edit)).

Fixes #55
@bors bors bot closed this as completed in #135 Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants