Add Appveyor Config for Windows CI #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@killercup - please may you get the necessary badge from https://ci.appveyor.com/project/killercup/cargo-edit and add it to the readme (assuming this builds OK)? |
|
Sweet! Thanks so much! Code for readme is [](https://ci.appveyor.com/project/killercup/cargo-edit/branch/master)Can you also the badges metadata to the Cargo.toml? (cf. http://doc.crates.io/manifest.html#package-metadata) |
|
Thanks. I'll add the badges to `Cargo.toml` and the readme and then merge.
|
ordian
reviewed
Jul 3, 2017
appveyor.yml
Outdated
| - TARGET: i686-pc-windows-msvc | ||
| - TARGET: i686-pc-windows-gnu | ||
| install: | ||
| - ps: Start-FileDownload "https://static.rust-lang.org/dist/rust-nightly-${env:TARGET}.exe" |
There was a problem hiding this comment.
Is this testing nightly?
I think we should only test stable on Windows, because nightly can fail and we're testing other channels on linux.
See appveyor example.
There was a problem hiding this comment.
That looks like a nicer way of doing things - I've just switched over verbatim.
|
@bjgill Could you please squash the commits? |
Add Appveyor-based Windows CI for 32/64bit msvc/gnu Windows. Also include a full set of badges in the readme and Cargo.toml
|
Thanks. bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reprise of #49 - it seems to work again now (
).
Fixes #55