Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make att. level 3 button opacity-based #2602

Closed
1 of 11 tasks
RasmusKjeldgaard opened this issue Nov 14, 2022 · 2 comments · Fixed by #2735
Closed
1 of 11 tasks

[Enhancement] Make att. level 3 button opacity-based #2602

RasmusKjeldgaard opened this issue Nov 14, 2022 · 2 comments · Fixed by #2735
Assignees
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Milestone

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Nov 14, 2022

Describe the enhancement

The attention level 3 button should be changed from an outline to a see-through layer.
image

Describe the solution you'd like

Attention level 3 of the button should be implemented with themeColor specific variants for light, white and dark backgrounds. This means they will automatically adapt when placed inside cards.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Nov 14, 2022
@dennispedersen-bd
Copy link

Remember to adjust hover and pressed state acording to guidelines

@RasmusKjeldgaard
Copy link
Collaborator Author

New spec:
image

@alxzak alxzak added this to Kirby Dec 5, 2022
@alxzak alxzak added this to the Desktop ready milestone Jan 5, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this to 📙 Backlog in Kirby Jan 9, 2023
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Jan 9, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 📙 Backlog to 🚀 In Progress in Kirby Jan 9, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 💤 Impeeded in Kirby Jan 16, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💤 Impeeded to 🔎 Review pending in Kirby Jan 16, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
3 participants