[Enhancement] Always set themeColor default value #2684
Labels
enhancement
New feature or request
NOT Prioritized
Issue not yet prioritized and added to a Milestone
NOT Tech refined
Needs Tech kickoff - solution outlined and agreed
Describe the enhancement
Right now our themeColor concept is based on an attribute directive that handles theming for a couple of components.
This has one important limitation, as we cannot handle a default theme color on a per component basis. This is because projects have to actually use the themeColor input on components before our custom functionality kicks in and decorates e.g. the avatar with appropriate classes.
This is not a problem for most components, because they just have a default color that themeColor overwrites. But page, card and modal footer can contain other components (like buttons), and at the same time have different default colors to begin with (light for page and modal-footer, white for card). This means the button has no way to know what color its context has.
For example, the button currently assumes that it is on a light background, but when used on a card with its default white background, no context variables are set to inform the button that it is in fact presented on a white background.
This will make the concept outlined in #2602 inconsistent across surfaces in the app.
Describe the solution you'd like
Possibly recreate the themeColor functionality so the themeColor variable is 'owned'/implemented on each component and a default value is set, and initialization logic is run.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Refinement
Implementation
The contributor who wants to implement this issue should:
Review
Once the issue has been implemented and is ready for review:
The text was updated successfully, but these errors were encountered: