Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Remove isDestructive button input #2737

Closed
1 task done
RasmusKjeldgaard opened this issue Jan 10, 2023 · 0 comments · Fixed by #2739
Closed
1 task done

[Housekeeping] Remove isDestructive button input #2737

RasmusKjeldgaard opened this issue Jan 10, 2023 · 0 comments · Fixed by #2739

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Jan 10, 2023

Describe the housekeeping request

isDestructive is an undocumented input on the button that should only used internally, but is publicly available on the button component.

It is used to mark a button destructive in the alert component.

It can be removed in favor of applying the destructive class on the specific button inside the alert-component markup.

Have you considered any alternatives?

Leave it in there, but it complicated the button rework in #2602 and #2684

@RasmusKjeldgaard RasmusKjeldgaard added NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone housekeeping and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant