Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] generate mocks cannot find designsystem/core #2872

Closed
4 of 9 tasks
kodeaben opened this issue Feb 20, 2023 · 0 comments · Fixed by #2883
Closed
4 of 9 tasks

[BUG] generate mocks cannot find designsystem/core #2872

kodeaben opened this issue Feb 20, 2023 · 0 comments · Fixed by #2883
Assignees
Labels

Comments

@kodeaben
Copy link
Contributor

kodeaben commented Feb 20, 2023

Describe the bug

In the buildpipeline, the "Kirby setup" step failes with the following error:
tools/generate-mocks/generate-mocks.ts(6,26): error TS2307: Cannot find module '@kirbydesign/core/custom-elements' or its corresponding type declarations.
Screenshot 2023-02-20 at 10 17 07
The error was first seen in a PR after Kirby v8.0.0 was released.

Link to a failing build: https://github.com/kirbydesign/designsystem/actions/runs/4142850657/jobs/7329113678

Describe how to reproduce the bug

Go to the link

Which Kirby version was used?

8.0.0

What was the expected behavior?

Not to have an error

Add any screenshots

Please complete the following information:

N/A -> is't in the. pipeline

Are there any additional context?

The bug doesn't appear to happen locally, where core is symlinked

The bug appears to happen sporadically, since the following PR's were created and merged after the release of v.8.0.0, without the error occuring:
#2866
#2865


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@kodeaben kodeaben added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Feb 20, 2023
@kodeaben kodeaben self-assigned this Feb 20, 2023
@kodeaben kodeaben added this to Kirby Feb 20, 2023
@kodeaben kodeaben removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Feb 20, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in Kirby Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant