Fix failing workflow runs caused by node v18.14 #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusKjeldgaard
added
the
ignore-for-release
RasmusKjeldgaard
changed the title
github-actions
bot
temporarily deployed
to
pr-2872-generate-mocks-cannot-find-core
RasmusKjeldgaard
deleted the
bug/2872-generate-mocks-cannot-find-core
branch
This was referenced Feb 22, 2023
SigurdVilstrup
pushed a commit
that referenced
this pull request
Mar 28, 2023
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2872
What is the new behavior?
All workflow runs have been failing during the
Kirby setupaction, since this PR: #2828@jakobe identified that during this run: https://github.com/kirbydesign/designsystem/actions/runs/4122277468 the Kirby setup action did not fail for two of the workflow runs, only for 'Build Kirby Cookbook' - and the only difference is that it uses node v18.14 instead of v18.13.
In this PR we cap the version to v18.13 until we have figured out to migrate further.
Does this PR introduce a breaking change?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
[ ] Make sure you have implemented tests following the guidelines in: "The good: Test".[ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
[ ] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.