Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kirby-button attentionLevel 3 in kirby-page-footer #2866

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix kirby-button attentionLevel 3 in kirby-page-footer #2866

merged 1 commit into from
Feb 14, 2023

Conversation

mark-drastrup
Copy link
Contributor

@mark-drastrup mark-drastrup commented Feb 14, 2023 •
edited
Loading

Which issue does this PR close?

This PR closes no issue.

What is the new behavior?

A kirby-button with attentionLevel 3 will change the background color to grey in kirby-page-footer

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup added the fix Add this PR to the changelog as a bugfix label Feb 14, 2023
mictro
mictro approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@mictro mictro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great..

@mark-drastrup mark-drastrup merged commit a8b7a54 into develop Feb 14, 2023
@mark-drastrup mark-drastrup deleted the hotfix/attentionlevel3-in-page-footer branch February 14, 2023 12:36
@mark-drastrup mark-drastrup mentioned this pull request Feb 20, 2023
Closed
9 tasks
SigurdVilstrup pushed a commit that referenced this pull request Mar 28, 2023
@mark-drastrup @SigurdVilstrup
Fix kirby-button attentionLevel 3 in kirby-page-footer (#2866)
451de14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mictro mictro mictro approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mark-drastrup @mictro