Remove IntersectionObserver polyfill #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusKjeldgaard
added
the
ignore-for-release
github-actions
bot
temporarily deployed
to
pr-remove-intersectionobserver-polyfill
mark-drastrup
previously approved these changes
Dec 22, 2022
RasmusKjeldgaard
added
breaking-change
Base automatically changed from
houskeeping/remove-resizeobserver-polyfill
to
develop
December 22, 2022 10:36
RasmusKjeldgaard
force-pushed
the
housekeeping/remove-intersectionobserver-polyfill
branch
from
3ff6172 to
3fd3e85
Compare
github-actions
bot
temporarily deployed
to
pr-remove-intersectionobserver-polyfill
mark-drastrup
approved these changes
Dec 22, 2022
RasmusKjeldgaard
deleted the
housekeeping/remove-intersectionobserver-polyfill
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes no issue 😬
What is the new behavior?
InersectionObserver has been supported in major browsers for a long while, and our polyfill can safely be removed.
Does this PR introduce a breaking change?
If the IntersectionObserver polyfill has previously been copied from the Kirby package to your projects output folder compile time via
build > options > assetsinangular.jsonthat configuration should be removed, as Kirby no longer supplies a intersection-observer polyfill.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Make sure you have implemented tests following the guidelines in: "The good: Test".Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).Review
Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)When the pull request has been approved it will be merged to
developby Team Kirby.