Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reintroduced polyfills #2845

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Remove reintroduced polyfills #2845

merged 2 commits into from
Feb 7, 2023

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes no issue

What is the new behavior?

Polyfills were removed in #2701, but accidentally reintroduced when making the card a secondary entry in #2707.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby label Feb 7, 2023
@RasmusKjeldgaard RasmusKjeldgaard merged commit 907d5ad into develop Feb 7, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/remove-polyfill branch February 7, 2023 08:51
SigurdVilstrup pushed a commit that referenced this pull request Mar 28, 2023
@RasmusKjeldgaard @SigurdVilstrup
Remove reintroduced polyfills (#2845)
eeda83e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodeaben kodeaben kodeaben approved these changes

Assignees
No one assigned
Labels
ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusKjeldgaard @kodeaben