-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up warning logs in test suites #3194
Merged
RasmusKjeldgaard
merged 9 commits into
develop
from
housekeeping/3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
Sep 8, 2023
Merged
Clean up warning logs in test suites #3194
RasmusKjeldgaard
merged 9 commits into
develop
from
housekeeping/3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgreSanGit
added
housekeeping
ignore-for-release
Housekeeping, tooling etc. that have no relevance for consumers of Kirby
labels
Aug 1, 2023
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 1, 2023 14:26
Inactive
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 1, 2023 14:42
Inactive
RasmusKjeldgaard
changed the title
Clean up warning logs in test suites regarding custom component
Clean up warning logs in test suites
Aug 3, 2023
RasmusKjeldgaard
requested changes
Aug 3, 2023
libs/designsystem/empty-state/src/empty-state.component.integration.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/item-sliding/src/item-sliding.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/modal/src/modal-wrapper/modal-wrapper.component.integration.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/modal/src/modal-wrapper/modal-wrapper.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/modal/src/modal/alert/alert.component.spec.ts
Outdated
Show resolved
Hide resolved
…n-test-suites-regarding-custom-component
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 4, 2023 08:09
Inactive
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 4, 2023 08:11
Inactive
RasmusKjeldgaard
requested changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of details remain, before we are good to go!
libs/designsystem/card/src/card-as-button/card-as-button.directive.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/modal/v2/src/wrapper/wrapper.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/designsystem/checkbox/src/checkbox.component.integration.spec.ts
Outdated
Show resolved
Hide resolved
…n-test-suites-regarding-custom-component
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 31, 2023 08:07
Inactive
github-actions
bot
temporarily deployed
to
pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
August 31, 2023 08:24
Inactive
…n-test-suites-regarding-custom-component
…n-test-suites-regarding-custom-component
RasmusKjeldgaard
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 🎉
RasmusKjeldgaard
deleted the
housekeeping/3193-clean-up-warning-logs-in-test-suites-regarding-custom-component
branch
September 8, 2023 11:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
housekeeping
ignore-for-release
Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #3193
What is the new behavior?
Clean up warning logs for missing component declarations in test suites.
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.