Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warning logs in test suites #3194

Conversation

AgreSanGit
Copy link
Contributor

@AgreSanGit AgreSanGit commented Aug 1, 2023

Which issue does this PR close?

This PR closes #3193

What is the new behavior?

Clean up warning logs for missing component declarations in test suites.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit added housekeeping ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby labels Aug 1, 2023
@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 1, 2023 14:26 Inactive
@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 1, 2023 14:42 Inactive
@AgreSanGit AgreSanGit marked this pull request as ready for review August 2, 2023 08:36
@RasmusKjeldgaard RasmusKjeldgaard changed the title Clean up warning logs in test suites regarding custom component Clean up warning logs in test suites Aug 3, 2023
@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 4, 2023 08:09 Inactive
@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 4, 2023 08:11 Inactive
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of details remain, before we are good to go!

@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 31, 2023 08:07 Inactive
@github-actions github-actions bot temporarily deployed to pr-3193-clean-up-warning-logs-in-test-suites-regarding-custom-component August 31, 2023 08:24 Inactive
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) September 8, 2023 11:11
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 🎉

@RasmusKjeldgaard RasmusKjeldgaard merged commit 3adea36 into develop Sep 8, 2023
4 of 5 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the housekeeping/3193-clean-up-warning-logs-in-test-suites-regarding-custom-component branch September 8, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Clean up warning logs in Test suites regarding custom component
2 participants