Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warning logs in test suites #3194

Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { EmptyStateComponent } from '@kirbydesign/designsystem/empty-state';
import {
PageActionsDirective,
PageComponent,
PageModule,
PageTitleDirective,
} from '@kirbydesign/designsystem/page';
import { FitHeadingDirective } from '@kirbydesign/designsystem/shared';
Expand All @@ -35,6 +36,7 @@ describe('ButtonComponent in Kirby Page', () => {
RouterTestingModule,
ButtonComponent,
FitHeadingDirective,
PageModule,
],
declarations: [PageActionsDirective, PageTitleDirective],
providers: [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
import { createDirectiveFactory, SpectatorDirective } from '@ngneat/spectator';
import { Component } from '@angular/core';
import { CardComponent } from '../card.component';
import { CardAsButtonDirective } from './card-as-button.directive';

@Component({ selector: 'kirby-card-click-host', template: '' })
class KirbyCardClickHostComponent {
someMethod() {
//noop
}
}

describe('CardAsButtonDirective', () => {
let spectator: SpectatorDirective<CardAsButtonDirective>;
let cardElement: HTMLElement;
Expand All @@ -10,6 +18,7 @@ describe('CardAsButtonDirective', () => {
directive: CardAsButtonDirective,
imports: [],
declarations: [CardComponent],
host: KirbyCardClickHostComponent,
});
beforeEach(() => {
spectator = createDirective(`<kirby-card (click)="someMethod()"> </kirby-card>`);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { MockComponents } from 'ng-mocks';
import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';

import { ItemComponent } from '@kirbydesign/designsystem/item';
import { IconModule } from '@kirbydesign/designsystem/icon';
import { CheckboxComponent } from './checkbox.component';

const size = DesignTokenHelper.size;
Expand All @@ -14,6 +15,7 @@ describe('CheckboxComponent in Item', () => {

const createHost = createHostFactory({
component: CheckboxComponent,
imports: [IconModule],
declarations: MockComponents(ItemComponent),
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ import { createHostFactory, Spectator } from '@ngneat/spectator';
import { MockComponents } from 'ng-mocks';
import { CardComponent } from '@kirbydesign/designsystem/card';
import { IconComponent } from '@kirbydesign/designsystem/icon';
import { ItemComponent } from '@kirbydesign/designsystem/item';
import { ItemComponent, ItemModule } from '@kirbydesign/designsystem/item';

import { PopoverComponent } from '@kirbydesign/designsystem/popover';
import { ButtonComponent } from '@kirbydesign/designsystem/button';
import { TestHelper } from 'testing/src';
import { DropdownComponent } from './dropdown.component';

@Component({
Expand Down Expand Up @@ -44,6 +45,7 @@ describe('DropdownComponent + PopoverComponent', () => {
describe('with default change detection strategy', () => {
const createHost = createHostFactory({
component: DropdownComponent,
imports: [TestHelper.ionicModuleForTest, ItemModule],
declarations: [
ItemComponent,
MockComponents(ButtonComponent, IconComponent, IonItem),
Expand Down Expand Up @@ -141,6 +143,8 @@ describe('DropdownComponent + PopoverComponent', () => {
describe("with 'OnPush' change detection strategy", () => {
const createOnPushHost = createHostFactory({
component: DropdownComponent,
imports: [TestHelper.ionicModuleForTest, ItemModule],

declarations: [
PopoverComponent,
MockComponents(ButtonComponent, CardComponent, ItemComponent, IconComponent),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@ import { CardComponent } from '@kirbydesign/designsystem/card';

import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';
import { IconComponent } from '@kirbydesign/designsystem/icon';
import { ItemComponent } from '@kirbydesign/designsystem/item';
import { ItemComponent, ItemModule } from '@kirbydesign/designsystem/item';
import { HorizontalDirection, PopoverComponent } from '@kirbydesign/designsystem/popover';

import { ListItemTemplateDirective } from '@kirbydesign/designsystem/list';
import { ButtonComponent } from '@kirbydesign/designsystem/button';
import { TestHelper } from 'testing/src';
import { DropdownComponent } from './dropdown.component';
import { OpenState } from './dropdown.types';

Expand All @@ -34,6 +35,7 @@ describe('DropdownComponent (popover version)', () => {
describe('by default', () => {
const createHost = createHostFactory({
component: DropdownComponent,
imports: [TestHelper.ionicModuleForTest, ItemModule],
declarations: [
ItemComponent,
MockComponents(ButtonComponent, IconComponent, IonItem, PopoverComponent, CardComponent),
Expand Down Expand Up @@ -939,11 +941,10 @@ describe('DropdownComponent (popover version)', () => {

beforeEach(() => {
spectator = createHost(
`<kirby-dropdown>
`<kirby-dropdown [usePopover]="true">
<kirby-item
*kirbyListItemTemplate="let item; let selected = selected"
selectable="true"
[usePopover]="true"
[selected]="selected">
<kirby-icon *ngIf="selected" name="checkmark-selected" slot="start"></kirby-icon>
<h3>{{ item.title }}</h3>
Expand Down
3 changes: 2 additions & 1 deletion libs/designsystem/dropdown/src/dropdown.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { MockComponents } from 'ng-mocks';
import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';
import { CardComponent } from '@kirbydesign/designsystem/card';
import { IconComponent } from '@kirbydesign/designsystem/icon';
import { ItemComponent } from '@kirbydesign/designsystem/item';
import { ItemComponent, ItemModule } from '@kirbydesign/designsystem/item';
import { HorizontalDirection, PopoverComponent } from '@kirbydesign/designsystem/popover';
import { ListItemTemplateDirective } from '@kirbydesign/designsystem/list';
import { ButtonComponent } from '@kirbydesign/designsystem/button';
Expand All @@ -34,6 +34,7 @@ describe('DropdownComponent', () => {
describe('by default', () => {
const createHost = createHostFactory({
component: DropdownComponent,
imports: [ItemModule],
declarations: [
ItemComponent,
MockComponents(ButtonComponent, CardComponent, IconComponent, IonItem, PopoverComponent),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,16 @@ import { MockComponent } from 'ng-mocks';
import { IconComponent } from '@kirbydesign/designsystem/icon';
import { ButtonComponent } from '@kirbydesign/designsystem/button';

import { EmptyStateComponent } from './empty-state.component';
import { PageComponent } from '@kirbydesign/designsystem/page';
import { EmptyStateComponent } from '@kirbydesign/designsystem/empty-state';

describe('EmptyStateComponent with slotted buttons', () => {
let spectator: SpectatorHost<EmptyStateComponent>;
let buttons: ButtonComponent[];

const createHost = createHostFactory({
component: EmptyStateComponent,
imports: [PageComponent],
declarations: [MockComponent(IconComponent), ButtonComponent],
});

Expand Down
13 changes: 12 additions & 1 deletion libs/designsystem/header/src/header.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';

import { FlagComponent } from 'flag/src';
import { AvatarComponent } from 'avatar/src';
import { IconModule } from 'icon/src';
import { ProgressCircleComponent } from 'progress-circle/src';
import { ActionGroupComponent } from 'action-group/src';
import { HeaderModule } from './header.module';
import { HeaderComponent } from './header.component';

Expand All @@ -13,7 +16,15 @@ const { fontSize, size } = DesignTokenHelper;
describe('HeaderComponent', () => {
const createHost = createHostFactory({
component: HeaderComponent,
imports: [TestHelper.ionicModuleForTest, HeaderModule, FlagComponent, AvatarComponent],
imports: [
TestHelper.ionicModuleForTest,
HeaderModule,
FlagComponent,
AvatarComponent,
IconModule,
ProgressCircleComponent,
ActionGroupComponent,
],
detectChanges: true,
});

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';
import { createHostFactory, SpectatorHost } from '@ngneat/spectator';

import { ItemSwipeActionType } from './item-sliding.types';
import { ItemSlidingComponent, ItemSwipeAction } from './';
import { ItemModule } from 'item/src';
import {
ItemSlidingComponent,
ItemSwipeAction,
ItemSwipeActionType,
} from '@kirbydesign/designsystem/item-sliding';

const { getColor } = DesignTokenHelper;

Expand All @@ -11,6 +15,7 @@ describe('ItemSlidingComponent', () => {

const createHost = createHostFactory({
component: ItemSlidingComponent,
imports: [ItemModule],
});

let ionItemOptionsElement: HTMLIonItemOptionsElement;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ import { createComponentFactory, Spectator } from '@ngneat/spectator';
import { TestHelper } from '@kirbydesign/designsystem/testing';

import { PageProgressComponent, PageTitleComponent } from '@kirbydesign/designsystem/page';
import { ModalFooterComponent } from '../modal/footer/modal-footer.component';
import { CanDismissHelper } from '../modal/services/can-dismiss.helper';
import { ModalWrapperComponent } from './modal-wrapper.component';
import { IconModule } from '@kirbydesign/designsystem/icon';
import {
CanDismissHelper,
ModalFooterComponent,
ModalWrapperComponent,
} from '@kirbydesign/designsystem/modal';

import {
DynamicFooterEmbeddedComponent,
DynamicPageProgressEmbeddedComponent,
Expand All @@ -19,7 +23,7 @@ import {
describe('ModalWrapperComponent + ModalFooterComponent', () => {
const createComponent = createComponentFactory({
component: ModalWrapperComponent,
imports: [RouterTestingModule, ModalFooterComponent],
imports: [RouterTestingModule, ModalFooterComponent, IconModule],
entryComponents: [StaticFooterEmbeddedComponent, DynamicFooterEmbeddedComponent],
mocks: [CanDismissHelper],
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import { IconComponent } from '@kirbydesign/designsystem/icon';
import { DesignTokenHelper, KirbyAnimation } from '@kirbydesign/designsystem/helpers';

import { ButtonComponent } from '@kirbydesign/designsystem/button';
import { CanDismissHelper } from '../modal/services/can-dismiss.helper';
import { ModalWrapperComponent } from './modal-wrapper.component';
import { PageModule } from '@kirbydesign/designsystem/page';
import { CanDismissHelper, ModalWrapperComponent } from '@kirbydesign/designsystem/modal';
import {
DynamicFooterEmbeddedComponent,
DynamicPageProgressEmbeddedComponent,
Expand All @@ -24,6 +24,7 @@ import {
describe('ModalWrapperComponent', () => {
const createComponent = createComponentFactory({
component: ModalWrapperComponent,
imports: [PageModule],
entryComponents: [
TitleEmbeddedComponent,
StaticFooterEmbeddedComponent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@ import { createHostFactory, SpectatorHost } from '@ngneat/spectator';

import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';

import { IconModule } from '@kirbydesign/designsystem/icon';
import { AlertComponent } from './alert.component';

const getColor = DesignTokenHelper.getColor;

describe('AlertComponent', () => {
let spectator: SpectatorHost<AlertComponent>;

const createHost = createHostFactory({
component: AlertComponent,
imports: [IconModule],
});

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';

import { IconModule } from '@kirbydesign/designsystem/icon';

import { ModalV2WrapperComponent } from './wrapper.component';

describe('WrapperComponent', () => {
Expand All @@ -8,6 +10,7 @@ describe('WrapperComponent', () => {

beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [IconModule],
declarations: [ModalV2WrapperComponent],
}).compileComponents();

Expand Down