Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: declare scss exports in package #3665

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Oct 11, 2024

Which issue does this PR close?

This PR closes an issue with missing scss exports from our core package, resulting in the following error when compiling the designsystem package in projects:
image

What is the new behavior?

The package exports field in the badge as web comp PR does not include the utils and global_styles scss partials that were previously exported by default.

They are now added as explicit exports.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Oct 11, 2024
Comment on lines +27 to +28
"./scss/global-styles": "./scss/_global-styles.scss",
"./scss/utils": "./scss/_utils.scss",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be wildcard export to avoid an error in the future, but that would mean we expose all our scss partials as part of our public package, so that would probably be a bit much 🤔

"./scss/*": {
  "sass": "./scss/_*.scss" 
},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's keep it as explicit exports 👍🏻

@github-actions github-actions bot temporarily deployed to pr-core-package-scss-exports October 11, 2024 13:41 Inactive
@RasmusKjeldgaard RasmusKjeldgaard merged commit 6fd39a0 into develop Oct 14, 2024
12 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the fix/core-package-scss-exports branch October 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants