Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: declare scss exports in package #3665

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Core: declare scss exports in package #3665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bd98d
Add scss exports to core
RasmusKjeldgaard Oct 11, 2024
df8aee7
Merge branch 'develop' into fix/core-package-scss-exports
jakobe Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
"types": "./dist/types/index.d.ts",
"default": "./dist/index.js"
},
"./scss/global-styles": "./scss/_global-styles.scss",
"./scss/utils": "./scss/_utils.scss",
Comment on lines +27 to +28
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be wildcard export to avoid an error in the future, but that would mean we expose all our scss partials as part of our public package, so that would probably be a bit much 🤔

"./scss/*": {
  "sass": "./scss/_*.scss" 
},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's keep it as explicit exports 👍🏻

"./src/scss/*": {
"style": "./src/scss/*"
},
Expand Down
Loading