Lock Cython to 0.29.17 in Numpy recipe #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Jul 19, 2023
| @@ -11,7 +11,7 @@ class NumpyRecipe(CythonRecipe): | |||
| libraries = ["libnpymath.a", "libnpyrandom.a"] | |||
| include_dir = "numpy/core/include" | |||
| depends = ["python"] | |||
| hostpython_prerequisites = ["Cython"] | |||
| hostpython_prerequisites = ["Cython==0.29.17"] | |||
There was a problem hiding this comment.
Don't we support lower than <
There was a problem hiding this comment.
I pulled the version for Cython from requirements.txt in the root of the repo, if there's a different version that should be locked to such as the latest build from v0.29 (0.29.36) that would make sense to me.
There was a problem hiding this comment.
On CI pipeline we use Cython==0.29.33, requirements.txt have Cython==0.29.17, on setup.cfg is unpinned, and on hostpython_prerequisites is also unpinned.
@jswillard what about pinning 0.29.36 everywhere? (for now, see: kivy/buildozer#1637 for full story)
CI fails on this PR as numpy complains about the following:
RuntimeError: Building NumPy requires Cython >= 0.29.30
|
Fixed via #844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cython3.0.0 was released yesterday and buildingnumpy< 1.25.0 is not supported withcython3.0 or newer. Without locking to a specificcythonversion, pip will grab the latest andnumpywill fail to build.I'm relatively new to using Kivy, so there may be a better way to accomplish this than changing the recipe file.