Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock Cython to 0.29.17 in Numpy recipe #834

Closed
wants to merge 1 commit into from
Closed

Lock Cython to 0.29.17 in Numpy recipe #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kivy_ios/recipes/numpy/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class NumpyRecipe(CythonRecipe):
libraries = ["libnpymath.a", "libnpyrandom.a"]
include_dir = "numpy/core/include"
depends = ["python"]
hostpython_prerequisites = ["Cython"]
hostpython_prerequisites = ["Cython==0.29.17"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we support lower than <

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the version for Cython from requirements.txt in the root of the repo, if there's a different version that should be locked to such as the latest build from v0.29 (0.29.36) that would make sense to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On CI pipeline we use Cython==0.29.33, requirements.txt have Cython==0.29.17, on setup.cfg is unpinned, and on hostpython_prerequisites is also unpinned.

@jswillard what about pinning 0.29.36 everywhere? (for now, see: kivy/buildozer#1637 for full story)

CI fails on this PR as numpy complains about the following:
RuntimeError: Building NumPy requires Cython >= 0.29.30

cythonize = False

def prebuild_arch(self, arch):
Expand Down
Loading