Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Pillow test app #1826

Merged
merged 1 commit into from
May 28, 2019
Merged

Add a Pillow test app #1826

merged 1 commit into from
May 28, 2019

Conversation

opacam
Copy link
Member

@opacam opacam commented May 27, 2019

So we can test Pillow and some of the libraries that Pillow depends on (freetype, harfbuzz, jpeg and png)

Some notes:

  • I used this testapp to test Rework of freetype/harfbuzz recipes #1825
  • The Pil operations performed in here are done with *.png images...but it could be enhanced to include some other tests with *.jpeg
  • I included some other tests (import ctypes and test vibration) but this last one will only work on Android Oreo +. This also applies to all other tests that we trigger the android's vibration and this is happening because vibrate was deprecated in API level 26. Since I still haven't the solution for this I put a todo as a reminder and wrote in here (maybe we should create a new issue about this...)

Also see: https://developer.android.com/reference/android/os/Vibrator

As a side note: I don't know if we should include this testapp in the master branch...whatever the team decide it's fine to me...but I wanted to share it so we could test the changes applied in the mentioned pr...so if anyone feels that we shouldn't merge this let me know or directly close it, no problem 😉

So we can test Pillow and some of the libraries that Pillow depends on (freetype, harfbuzz, jpeg and png)
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks.
I think we should start thinking about a more conventional unit test like architecture

@AndreMiras AndreMiras merged commit 1b8ba83 into kivy:master May 28, 2019
@opacam
Copy link
Member Author

opacam commented May 29, 2019

Oh yes, totally agree...but where to start? Implementing all the testapp's tests into on_device_unit_tests (#1636)? is this what are you thinking?

@opacam opacam deleted the testapp-pillow branch May 29, 2019 11:07
@AndreMiras
Copy link
Member

Yes kinda the idea indeed. There's no urge, but we should think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants