Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move png to mainline #1829

Closed
wants to merge 1 commit into from
Closed

[WIP] Move png to mainline #1829

wants to merge 1 commit into from

Conversation

opacam
Copy link
Member

@opacam opacam commented May 30, 2019

Also modify Pillow recipe because depends on png

This changes are friendly with #1822 which needs shared libraries for png and an specific name for the library libpng16.so

Note: tested with a Pillow test app and arch armv7a (#1826)

As a side note: untouched Pil recipe, because it's removed in #1822, so we avoid solve conflicts in there...but, we will broke the Pil recipe...so...be careful with merging this. That it's why I leave it labeled WIP and because it would be great to test with matplotlib recipe before merging this, so we can avoid surprises...

Also modify Pillow recipe because depends on png
@opacam opacam added the WIP label May 30, 2019
@inclement
Copy link
Member

Thanks @opacam, I'll pull these commits into #1822 to resolve the pil issue.

@opacam
Copy link
Member Author

opacam commented Jun 3, 2019

Oh yes, no problem, feel free to close this pr if you want to include this with matplotlib recipe 😉

@inclement
Copy link
Member

Changes merged into #1822, thanks!

@inclement inclement closed this Jun 3, 2019
@opacam opacam deleted the png-mainline branch June 7, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants