[WIP] Fix foreground notification being mandatory and more #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes that right now the service always slaps up a notification without this being configurable at runtime. It only is configurable right now if setting the foreground property via --service, which cannot be done when using the simpler service/main.py entrypoint - Fixes service_only service code template not rendering .foreground correctly since it added an outdated, useless function name override - Fixes notification channel name which is visible to end user hardcoding "python" in its name which is not ideal for end user naming (since the average user might not even know what python is) - Fixes override of doStartForeground() leading to quite some error-prone code duplication
ghost
mentioned this pull request
|
Closing in favor of #1888 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix foreground notification being mandatory and more. Details:
Fixes that right now the service always slaps up a notification
without this being configurable at runtime. It only is configurable
right now if setting the foreground property via --service, which
cannot be done when using the simpler service/main.py entrypoint
Fixes service_only service code template not rendering .foreground
correctly since it added an outdated, useless function name override
Fixes notification channel name which is visible to end user
hardcoding "python" in its name which is not ideal for end user
naming (since the average user might not even know what python is)
Fixes override of doStartForeground() leading to quite some
error-prone code duplication