Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix foreground notification being mandatory and more #1886

Closed
wants to merge 1 commit into from
Closed

[WIP] Fix foreground notification being mandatory and more #1886

wants to merge 1 commit into from

Commits on Jun 25, 2019

  1. Fix foreground notification being mandatory and more. Details: 

    - Fixes that right now the service always slaps up a notification
  without this being configurable at runtime. It only is configurable
  right now if setting the foreground property via --service, which
  cannot be done when using the simpler service/main.py entrypoint

- Fixes service_only service code template not rendering .foreground
  correctly since it added an outdated, useless function name override

- Fixes notification channel name which is visible to end user
  hardcoding "python" in its name which is not ideal for end user
  naming (since the average user might not even know what python is)

- Fixes override of doStartForeground() leading to quite some
  error-prone code duplication
    Jonas Thiem committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    7a7d8ee View commit details
    Browse the repository at this point in the history