Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces pkg_config_location in Prerequisite and use OpenSSLPrerequisite().pkg_config_location in hostpython3, so we can support ssl on hostpython3 just out of the box also on macOS #2599

Merged
merged 2 commits into from
May 21, 2022

Conversation

misl6
Copy link
Member

@misl6 misl6 commented May 21, 2022

✂️ (Partially) from #2586

  • hostpython3 requires PKG_CONFIG_PATH to be set on macOS in order to have ssl support (which is needed by pip)
  • Introduces pkg_config_location property in Prerequisite.
  • Introduced homebrew_formula_name in Prerequisite, to avoid some DRY violations.

…isite().pkg_config_location in hostpython3, so we can support ssl on hostpython3 just out of the box also on macOS
AndreMiras
AndreMiras previously approved these changes May 21, 2022
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@misl6 misl6 merged commit 71c237f into kivy:develop May 21, 2022
@misl6 misl6 deleted the fix/build-hostpython3-ssl-pkgconfig branch May 21, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants