Added pythonforandroid.androidndk.AndroidNDK + some changes needed in order to support build on Apple Silicon macs. #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misl6
force-pushed
the
fix/build-platform-on-m1
branch
10 times, most recently
from
c607cc9 to
61314e9
Compare
|
✅ All tests are successful (also the ones on device) |
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
a018304 to
6370886
Compare
This was referenced May 1, 2022
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
f980c39 to
346db77
Compare
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
c259bac to
b0489af
Compare
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
8994795 to
00ef94c
Compare
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
bd72606 to
f91970e
Compare
misl6
force-pushed
the
fix/build-platform-on-m1
branch
from
f91970e to
23ceb2f
Compare
This was referenced May 26, 2022
misl6
force-pushed
the
fix/build-platform-on-m1
branch
2 times, most recently
from
288008a to
41b946e
Compare
misl6
force-pushed
the
fix/build-platform-on-m1
branch
6 times, most recently
from
d4ddb31 to
5fdde17
Compare
misl6
changed the title
AndreMiras
previously approved these changes
Jul 11, 2022
… order to support build on Apple Silicon macs.
misl6
force-pushed
the
fix/build-platform-on-m1
branch
from
5fdde17 to
ff9c1ff
Compare
Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com>
AndreMiras
approved these changes
Jul 12, 2022
This was referenced Jul 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It started as a minor change to the codebase in order to support builds on Apple Silicon without the aid of Rosetta.
Unfortunately, while doing changes, a lot of issues come up during CI runs (and locally on my M1 Mac), so this PR started to be something bigger, that fixes broken recipes and introduces the new
pythonforandroid.androidndk.AndroidNDK.This is a WIP PR to track down the current work around
python-for-androidrecipes, and is needed in order to launch tests on our self-hosted Apple Silicon runner.