Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CriteriaQueries utility class #1008

Closed
sleberknight opened this issue Aug 6, 2023 · 0 comments · Fixed by #1009
Closed

Remove CriteriaQueries utility class #1008

sleberknight opened this issue Aug 6, 2023 · 0 comments · Fixed by #1009
Assignees
Labels
API change Change to a public API
Milestone

Comments

@sleberknight
Copy link
Member

Hibernate 6.x removes the Hibernate Criteria API, so this class must be removed.

@sleberknight sleberknight added the API change Change to a public API label Aug 6, 2023
@sleberknight sleberknight added this to the 3.0.0 milestone Aug 6, 2023
@sleberknight sleberknight self-assigned this Aug 6, 2023
sleberknight added a commit that referenced this issue Aug 6, 2023
* Update kiwi-parent and kiwi-bom
* Update build to use 17 and 20, and run Sonar on 17
* Update CodeQL to run on 17
* Refactor javax to jakarta packages
* Refactor Dropwizard package name changes
* Update javadoc errors in TlsContextConfiguration
* Large-ish changes to user types (see notes below)
* Remove CriteriaQueries since Hibernate 6.x removes its Criteria API
* Update groupId for hibernate to org.hibernate.orm

Hibernate UserType changes:

Hibernate 6.x made some public API changes to UserType, notably adding
a generic type parameter. This required refactoring our user type
classes: JSONBUserType, AbstractArrayUserType, BigintArrayUserType,
and TextArrayUserType. The integration tests pass, so I am mostly
confident these changes will work in the "real world".

One other large change is that Hibernate now requires Postgres 10 as
the minimum version, which required changing the dialect in
UserTypeTestHelpers from PostgreSQL95Dialect (which no longer exists
in Hibernate 6.x) to PostgreSQLDialect.

Misc cleanup:

* Remove redundant empty string concatenation in VaultEncryptedVariable
* Fix incorrect javadoc on JsonDetectionResult#getErrorOrNull
* Use java.time.Instant instead of org.joda.time.Instant in KiwiIOTest
* Minor updates and cleanup in KiwiStandardResponsesIntegrationTest
* Remove redundant warning suppression in JsonHelperAdvancedFeaturesTest
* Refactor (extract method) in PropertyMaskingSafePropertyWriterTest
* Fix infinite recursion issue in KiwiReflectionTest in AddingFactory
  class and suppress the unused warnings
* Fix javadoc error in AbstractPagingQueryIntegrationTest

Closes #1007
Closes #1008
sleberknight added a commit that referenced this issue Aug 6, 2023
* Update kiwi-parent and kiwi-bom
* Update build to use 17 and 20, and run Sonar on 17
* Update CodeQL to run on 17
* Refactor javax to jakarta packages
* Refactor Dropwizard package name changes
* Update javadoc errors in TlsContextConfiguration
* Large-ish changes to user types (see notes below)
* Remove CriteriaQueries since Hibernate 6.x removes its Criteria API
* Update groupId for hibernate to org.hibernate.orm

Hibernate UserType changes:

Hibernate 6.x made some public API changes to UserType, notably adding
a generic type parameter. This required refactoring our user type
classes: JSONBUserType, AbstractArrayUserType, BigintArrayUserType,
and TextArrayUserType. The integration tests pass, so I am mostly
confident these changes will work in the "real world".

One other large change is that Hibernate now requires Postgres 10 as
the minimum version, which required changing the dialect in
UserTypeTestHelpers from PostgreSQL95Dialect (which no longer exists
in Hibernate 6.x) to PostgreSQLDialect.

Misc cleanup:

* Remove redundant empty string concatenation in VaultEncryptedVariable
* Fix incorrect javadoc on JsonDetectionResult#getErrorOrNull
* Use java.time.Instant instead of org.joda.time.Instant in KiwiIOTest
* Minor updates and cleanup in KiwiStandardResponsesIntegrationTest
* Remove redundant warning suppression in JsonHelperAdvancedFeaturesTest
* Refactor (extract method) in PropertyMaskingSafePropertyWriterTest
* Fix infinite recursion issue in KiwiReflectionTest in AddingFactory
  class and suppress the unused warnings
* Fix javadoc error in AbstractPagingQueryIntegrationTest

Closes #1007
Closes #1008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Change to a public API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant