Massive updates for Dropwizard 4.x, Hibernate 6, Spring 6, etc. #1009

sleberknight · 2023-08-06T19:50:45Z

Update kiwi-parent and kiwi-bom
Update build to use 17 and 20, and run Sonar on 17
Update CodeQL to run on 17
Refactor javax to jakarta packages
Refactor Dropwizard package name changes
Update javadoc errors in TlsContextConfiguration
Large-ish changes to user types (see notes below)
Remove CriteriaQueries since Hibernate 6.x removes its Criteria API
Update groupId for hibernate to org.hibernate.orm

Hibernate UserType changes:

Hibernate 6.x made some public API changes to UserType, notably adding a generic type parameter. This required refactoring our user type classes: JSONBUserType, AbstractArrayUserType, BigintArrayUserType, and TextArrayUserType. The integration tests pass, so I am mostly confident these changes will work in the "real world".

One other large change is that Hibernate now requires Postgres 10 as the minimum version, which required changing the dialect in UserTypeTestHelpers from PostgreSQL95Dialect (which no longer exists in Hibernate 6.x) to PostgreSQLDialect.

Misc cleanup:

Remove redundant empty string concatenation in VaultEncryptedVariable
Fix incorrect javadoc on JsonDetectionResult#getErrorOrNull
Use java.time.Instant instead of org.joda.time.Instant in KiwiIOTest
Minor updates and cleanup in KiwiStandardResponsesIntegrationTest
Remove redundant warning suppression in JsonHelperAdvancedFeaturesTest
Refactor (extract method) in PropertyMaskingSafePropertyWriterTest
Fix infinite recursion issue in KiwiReflectionTest in AddingFactory class and suppress the unused warnings
Fix javadoc error in AbstractPagingQueryIntegrationTest

Closes #1007
Closes #1008

* Update kiwi-parent and kiwi-bom * Update build to use 17 and 20, and run Sonar on 17 * Update CodeQL to run on 17 * Refactor javax to jakarta packages * Refactor Dropwizard package name changes * Update javadoc errors in TlsContextConfiguration * Large-ish changes to user types (see notes below) * Remove CriteriaQueries since Hibernate 6.x removes its Criteria API * Update groupId for hibernate to org.hibernate.orm Hibernate UserType changes: Hibernate 6.x made some public API changes to UserType, notably adding a generic type parameter. This required refactoring our user type classes: JSONBUserType, AbstractArrayUserType, BigintArrayUserType, and TextArrayUserType. The integration tests pass, so I am mostly confident these changes will work in the "real world". One other large change is that Hibernate now requires Postgres 10 as the minimum version, which required changing the dialect in UserTypeTestHelpers from PostgreSQL95Dialect (which no longer exists in Hibernate 6.x) to PostgreSQLDialect. Misc cleanup: * Remove redundant empty string concatenation in VaultEncryptedVariable * Fix incorrect javadoc on JsonDetectionResult#getErrorOrNull * Use java.time.Instant instead of org.joda.time.Instant in KiwiIOTest * Minor updates and cleanup in KiwiStandardResponsesIntegrationTest * Remove redundant warning suppression in JsonHelperAdvancedFeaturesTest * Refactor (extract method) in PropertyMaskingSafePropertyWriterTest * Fix infinite recursion issue in KiwiReflectionTest in AddingFactory class and suppress the unused warnings * Fix javadoc error in AbstractPagingQueryIntegrationTest Closes #1007 Closes #1008