Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OsCommand in base.process package to replace the one in ansible.vault #1025

Closed
sleberknight opened this issue Aug 26, 2023 · 0 comments · Fixed by #1028
Closed

Create OsCommand in base.process package to replace the one in ansible.vault #1025

sleberknight opened this issue Aug 26, 2023 · 0 comments · Fixed by #1028
Assignees
@sleberknight
Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Milestone
3.1.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Aug 26, 2023 •
edited
Loading

Create a new OsCommand interface in the org.kiwiproject.base.process package, which replaces the one in the org.kiwiproject.ansible.vault package.

In addition, enhance it with the ability to convert the OsCommand to a String[] in addition to the existing conversion to a List<String>, which lets it be used with either form of the JDK ProcessBuilder or our own ProcessHelper and Processes classes.

This replaces the existing, and soon-to-be-deprecated, OsCommand in the ansible.vault package.
@sleberknight sleberknight added the new feature A new feature such as a new class, method, package, group of classes, etc. label Aug 26, 2023
@sleberknight sleberknight added this to the 3.1.0 milestone Aug 26, 2023
@sleberknight sleberknight self-assigned this Aug 26, 2023
This was referenced Aug 26, 2023
Closed
Closed
sleberknight added a commit that referenced this issue Aug 26, 2023
@sleberknight
Create OsCommand interface in base.process package
8764bea 
This replaces the OsCommand in the ansible.vault package. It
simplifies the name of the method to obtain the command parts
as a List<String> from getCommandParts to just parts. It also
adds a default method, partsAsArray, to obtain the command
parts as a String array.

Closes #1025
@sleberknight sleberknight mentioned this issue Aug 26, 2023
Merged
terezivy pushed a commit that referenced this issue Aug 26, 2023
@sleberknight
Create OsCommand interface in base.process package (#1028)
c3863e3 
This replaces the OsCommand in the ansible.vault package. It
simplifies the name of the method to obtain the command parts
as a List<String> from getCommandParts to just parts. It also
adds a default method, partsAsArray, to obtain the command
parts as a String array.

Closes #1025
This was referenced Aug 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
new feature A new feature such as a new class, method, package, group of classes, etc.
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Create OsCommand interface in base.process package kiwiproject/kiwi
1 participant
@sleberknight