Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of deprecated OsCommand with new one from base.process package #1027

Closed
sleberknight opened this issue Aug 26, 2023 · 0 comments · Fixed by #1030
Closed

Replace usages of deprecated OsCommand with new one from base.process package #1027

sleberknight opened this issue Aug 26, 2023 · 0 comments · Fixed by #1030
Assignees
@sleberknight
Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Milestone
3.1.0

Comments

@sleberknight
Copy link
Member

Once #1026 and #1025 are complete, replace all the usages of the deprecated OsCommand class in the ansible.vault package with the new one in the base.process package.
@sleberknight sleberknight added the code cleanup Fix issues reported by Sonar or any other code analysis tools label Aug 26, 2023
@sleberknight sleberknight added this to the 3.1.0 milestone Aug 26, 2023
@sleberknight sleberknight self-assigned this Aug 26, 2023
sleberknight added a commit that referenced this issue Aug 27, 2023
@sleberknight
Replace usages of deprecated org.kiwiproject.ansible.vault.OsCommand
716d2e9 
* Replace all usages with org.kiwiproject.base.process.OsCommand
* Refactor existing AnsibleXxxCommand classes to implement
  org.kiwiproject.base.process.OsCommand
* Deprecate all the #getCommandParts methods in the AnsibleXxxCommand
  classes for removal; they are replaced by #parts. But since they
  are part of the public API, we need to first deprecate them
  and then remove them in the next major version, 4.0.0
* Update tests to use #parts method instead of #getCommandParts, but
  also add assertions that still test the old methods (and suppress
  the warnings about usages of code that is deprecated for removal)

Closes #1027
This was referenced Aug 27, 2023
Merged
Closed
sleberknight added a commit that referenced this issue Aug 27, 2023
@sleberknight
Replace usages of deprecated org.kiwiproject.ansible.vault.OsCommand (#…
e959775 
…1030)

* Replace all usages with org.kiwiproject.base.process.OsCommand
* Refactor existing AnsibleXxxCommand classes to implement
  org.kiwiproject.base.process.OsCommand
* Deprecate all the #getCommandParts methods in the AnsibleXxxCommand
  classes for removal; they are replaced by #parts. But since they
  are part of the public API, we need to first deprecate them
  and then remove them in the next major version, 4.0.0
* Update tests to use #parts method instead of #getCommandParts, but
  also add assertions that still test the old methods (and suppress
  the warnings about usages of code that is deprecated for removal)

Closes #1027
Closes #1031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
code cleanup Fix issues reported by Sonar or any other code analysis tools
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Replace usages of deprecated org.kiwiproject.ansible.vault.OsCommand kiwiproject/kiwi
1 participant
@sleberknight