Add ability to launch a Process with a working directory #739
Assignees
Labels
new feature
A new feature such as a new class, method, package, group of classes, etc.
Milestone
Comments
sleberknight
added
the
new feature
sleberknight
added a commit
that referenced
this issue
Jun 23, 2022
* Add overloads of Processes#launch and ProcessHelper#launch that accept a File representing the working directory and a List that contains the command. Did not overload the launch methods that accept varargs because there can be ambiguity as to which method is called. For example, launch(null, "git", "status") is ambiguous since both launch(String...) and launch(File, String...) can apply and that would force ugly casts, etc. * Update javadocs for Processes#waitForExit noting that we do not destroy the Process if the timeout occurs before the process exits Closes #739
sleberknight
added a commit
that referenced
this issue
Jun 23, 2022
* Add overloads of Processes#launch and ProcessHelper#launch that accept a File representing the working directory and a List that contains the command. Did not overload the launch methods that accept varargs because there can be ambiguity as to which method is called. For example, launch(null, "git", "status") is ambiguous since both launch(String...) and launch(File, String...) can apply and that would force ugly casts, etc. * Update javadocs for Processes#waitForExit noting that we do not destroy the Process if the timeout occurs before the process exits Closes #739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Java's
ProcessBuildercontains a lot more flexibility than we generally need when launching processes. However, a bunch of times recently I've needed to launch processes in the context of a specific working directory (e.g.gitcommands only make sense when in the project directory, and the same is true when running Maven commands).This is to add an overloaded
launchmethod inProcessesandProcessHelperthat accepts a working directory in addition to the command. To avoid ambiguity with varargs parameters in thelaunch(String... command)methods, probably best to only overload thelaunchmethods that accept aList<String>.Since
ProcessBuilder#directory(File)accepts aFileargument, that's probably what these new methods should accept as well. We could also add two overloads, one that accepts aFileand one that acceptsPath, the latter we can easily convert to aFile.The text was updated successfully, but these errors were encountered: