Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to launch processes with a working directory #741

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

sleberknight
Copy link
Member

  • Add overloads of Processes#launch and ProcessHelper#launch that
    accept a File representing the working directory and a List that
    contains the command. Did not overload the launch methods that accept
    varargs because there can be ambiguity as to which method is called.
    For example, launch(null, "git", "status") is ambiguous since both
    launch(String...) and launch(File, String...) can apply and that
    would force ugly casts, etc.
  • Update javadocs for Processes#waitForExit noting that we do not
    destroy the Process if the timeout occurs before the process exits

Closes #739

* Add overloads of Processes#launch and ProcessHelper#launch that
  accept a File representing the working directory and a List that
  contains the command. Did not overload the launch methods that accept
  varargs because there can be ambiguity as to which method is called.
  For example, launch(null, "git", "status") is ambiguous since both
  launch(String...) and launch(File, String...) can apply and that
  would force ugly casts, etc.
* Update javadocs for Processes#waitForExit noting that we do not
  destroy the Process if the timeout occurs before the process exits

Closes #739
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit a023f4e into master Jun 23, 2022
@sleberknight sleberknight deleted the 739_launch_processes_with_working_directory branch June 23, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to launch a Process with a working directory
2 participants