Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Spring Data 3.2.4 and Mongo 4.2.3 #593

Closed
wants to merge 15 commits into from
Closed

Update to Spring Data 3.2.4 and Mongo 4.2.3 #593

wants to merge 15 commits into from

Conversation

sleberknight
Copy link
Member

  • Bump spring-data-mongodb from 2.2.13 to 3.2.4
  • Add mongodb-driver-sync dependency since the mongo drivers are
    optional in spring-data-mongodb, so you have to choose one explicitly
  • Add new mongodb version property to the POM, along with a note that
    it should match the mongo version used by spring-data-mongodb
  • Fix all the things that broke/would not compile with the new versions
  • Deprecate MongoClientWrapper since it doesn't make sense or add any
    value anymore

@sleberknight
Update to Spring Data 3.2.4 and Mongo 4.2.3
1911b35 
* Bump spring-data-mongodb from 2.2.13 to 3.2.4
* Add mongodb-driver-sync dependency since the mongo drivers are
  optional in spring-data-mongodb, so you have to choose one explicitly
* Add new mongodb version property to the POM, along with a note that
  it should match the mongo version used by spring-data-mongodb
* Fix all the things that broke/would not compile with the new versions
* Deprecate MongoClientWrapper since it doesn't make sense or add any
  value anymore
@sleberknight
Copy link
Member Author

@terezivy and @chrisrohr I just ran this branch against a local Docker container running Mongo 5.0.2 and the PagingQueryRealMongoTest passed. Admittedly, this is the only one of our Mongo tests that runs against a "real" Mongo instance and not the embedded "flapdoodle" Mongo library, and it only tests a very limited number of things, but the fact that it did pass is still a good thing.

@terezivy
Copy link

That tracks with what I've found in my limited testing as well. I think that bodes well for a not monumentally painful transition.

@sleberknight
Don't assume default Mongo port is open in PagingQueryEmbeddedMongoTe…
c82d6e8 
…st (#594)

* Change PagingQueryEmbeddedMongoTest so that it doesn't just assume the
  default Mongo port (27017) is open and attempt to start the embedded
  Mongo server anyway. Instead, use LocalPortChecker to find the first
  port available starting with 27017. This will allow the test to run
  if there is actually a local Mongo server running.
@sleberknight
Add findFirstOpenPortFrom() method to LocalPortChecker (#596)
6b8988e 
* Add new method LocalPortChecker#findFirstOpenPortFrom
* Add "throws" declaration to javadoc for isPortAvailable and
  findFirstOpenPortAbove
* Restructure the test to use nested classes, and add new tests for
  the new findFirstOpenPortFrom() method

Closes #595
@sleberknight
Copy link
Member Author

@dependabot rebase

sleberknight and others added 6 commits August 23, 2021 12:39
@sleberknight
LocalPortChecker#isPortAvailable should not accept zero (#598)
c1b57fb 
* Throw an IllegalArgumentException if zero is supplied as an argument
  to LocalPortChecker#isPortAvailable

Closes #597
@dependabot @sleberknight
Bump kiwi-parent from 0.15.0 to 1.0.0 (#602)
21cf30d 
Bumps [kiwi-parent](https://github.com/kiwiproject/kiwi-parent) from 0.15.0 to 1.0.0.
- [Release notes](https://github.com/kiwiproject/kiwi-parent/releases)
- [Commits](kiwiproject/kiwi-parent@v0.15.0...v1.0.0)

---
updated-dependencies:
- dependency-name: org.kiwiproject:kiwi-parent
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @sleberknight
Bump retrying-again from 0.7.0 to 1.0.0 (#601)
d399cbe 
Bumps [retrying-again](https://github.com/kiwiproject/retrying-again) from 0.7.0 to 1.0.0.
- [Release notes](https://github.com/kiwiproject/retrying-again/releases)
- [Commits](kiwiproject/retrying-again@v0.7.0...v1.0.0)

---
updated-dependencies:
- dependency-name: org.kiwiproject:retrying-again
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @sleberknight
Bump dropwizard.version from 2.0.24 to 2.0.25 (#600)
877738c 
* Bump dropwizard.version from 2.0.24 to 2.0.25

Bumps `dropwizard.version` from 2.0.24 to 2.0.25.

Updates `dropwizard-client` from 2.0.24 to 2.0.25

Updates `dropwizard-jdbi3` from 2.0.24 to 2.0.25

Updates `dropwizard-testing` from 2.0.24 to 2.0.25

---
updated-dependencies:
- dependency-name: io.dropwizard:dropwizard-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.dropwizard:dropwizard-jdbi3
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.dropwizard:dropwizard-testing
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix convergence errors and misc minor updates

* Bump kiwi-parent from 0.15.0 to 1.0.0
* Bump kiwi version from 0.26.0-SNAPSHOT to 1.0.0-SNAPSHOT
* Bump hibernate from 5.5.3.Final to 5.5.7.Final
* Bump jakarta-el version from 3.0.3 to 3.0.4
* Bump error_prone_annotations from 2.8.0 to 2.9.0
* Bump embedded-postgres from 1.3.0 to 1.3.1

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Leberknight <174812+sleberknight@users.noreply.github.com>
@sleberknight
[maven-release-plugin] prepare release v1.0.0
13d45f9
@sleberknight
[maven-release-plugin] prepare for next development iteration
e743889
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

sleberknight and others added 6 commits October 19, 2021 16:42
@sleberknight
Add toWebTarget "escape hatch" to WebTargetHelper (#606)
e8d4b2a 
Closes #605
@sleberknight
Bump kiwi-parent from 1.0.0 to 1.1.0 (#607)
d35e901
@sleberknight
Add custom Jackson deserializer ListToCsvStringDeserializer (#609)
5ddcaba 
* Add custom Jackson deserializer ListToCsvStringDeserializer

Copied the original implementation from the service-discovery-client
library in kiwiproject, then made several modifications:

* Extend StdDeserializer instead of JsonDeserializer (per the Jackson
  Javadocs for JsonDeserializer); this required adding a public no-arg
  constructor that calls one of the protected superclass constructors.
* Check that JsonParser#getCodec returns a non-null ObjectCodec; throw
  an IllegalStateException with a useful-ish error message if null.
* Enhance Javadocs to clarify usage, restrictions, and limitations of
  this deserializer.

Closes #608
@dependabot @sleberknight
Bump actions/checkout from 2.3.4 to 2.3.5 (#610)
462c0b8 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sleberknight
Remove redundant toString() calls in KiwiUrls and KiwiStringsTest (#612)
60b2efe 
Closes #611
@sleberknight
Fix invalid "see" tags in javadoc in KiwiUrls (#614)
4bbaa30 
Closes #613
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sleberknight
Copy link
Member Author

Closing this PR, since it has diverged from master and it was easier to simply create a new branch with only the Mongo differences. The new PR is #615

@sleberknight sleberknight deleted the spring-data-3.2.4-and-mongo-4.2.3-update branch October 21, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sleberknight @terezivy