Update to Spring Data 3.2.4 and Mongo 4.2.3 #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump spring-data-mongodb from 2.2.13 to 3.2.4 * Add mongodb-driver-sync dependency since the mongo drivers are optional in spring-data-mongodb, so you have to choose one explicitly * Add new mongodb version property to the POM, along with a note that it should match the mongo version used by spring-data-mongodb * Fix all the things that broke/would not compile with the new versions * Deprecate MongoClientWrapper since it doesn't make sense or add any value anymore
* Change KiwiUrls#queryStringToMap so that it does not throw IllegalStateException if given a query string containing a parameter having multiple values, e.g. nickname=bob&nickname=bobby * The new implementation will always return the first value * Add documentation stating this limitation Fixes #617
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2.3.5...v2.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* extractAllFrom: change "all of the" to "all the" (redundant phrase) * extractAllFrom: add leading quote around the URL * replaceDomainsIn: fix misspelled argument name (replacementDomain) * replaceDomain: change "b" to "be"
|
Kudos, SonarCloud Quality Gate passed! |
terezivy
approved these changes
Dec 8, 2021
sleberknight
commented
Jan 18, 2022
| <dependency> | ||
| <groupId>org.mongodb</groupId> | ||
| <artifactId>mongodb-driver-sync</artifactId> | ||
| <version>${mongodb.version}</version> |
There was a problem hiding this comment.
this should probably be provided scope
sleberknight
commented
Jan 18, 2022
sleberknight
commented
Jan 18, 2022
| <postgresql.version>42.2.23</postgresql.version> | ||
| <retrying-again.version>1.0.0</retrying-again.version> | ||
| <spring.version>5.3.9</spring.version> | ||
| <spring-data-mongodb.version>2.2.13.RELEASE</spring-data-mongodb.version> | ||
| <spring-data-mongodb.version>3.2.4</spring-data-mongodb.version> |
There was a problem hiding this comment.
out of date; we just got a new PR for v3.3.1 for kiwi-bom (see kiwiproject/kiwi-bom#71 )
There was a problem hiding this comment.
and now one for v3.3.2 ; see again kiwiproject/kiwi-bom#71 (3.3.1) and kiwiproject/kiwi-bom#91 (3.3.2)
sleberknight
commented
Jan 18, 2022
|
This is superseded by #709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional in spring-data-mongodb, so you have to choose one explicitly
it should match the mongo version used by spring-data-mongodb
value anymore