please check sourceset #1195
please check sourceset #1195
Conversation
…licationComponent.
| @@ -339,6 +339,9 @@ android { | |||
|
|
|||
| // Set each custom apps respective source directory | |||
| sourceSets { | |||
| main { | |||
| java.srcDirs = ['src/main/java', 'build/generated/source/kapt/kiwixRelease'] | |||
There was a problem hiding this comment.
This is when you try to build a custom app? Hardcoding the variant is definitely not a good idea, it is possible that you could build it but just need a file refresh? Can you switch to my branch, file>invalidate caches and restart, build and then run?
There was a problem hiding this comment.
the goal was to find a minimal commit to convert an android java application, here the branch "develop", so that it can accomodate a kotlin application file. to learn, i looked at branch macgills/2.5-kotlin and its commits. as test i converted app/KiwixApplication.java with AndroidStudio to app/KiwixApplication.kt. the reasoning was that starting from the top of the logic would need the least adjustments in other files. the try is in soloturn/kotlin now, not compiling.
taking your 2.5-kotlin as base, i tried now again and pushed soloturn/2.5-kotlin. for me it does not build with
/srv/http/kiwix-android/app/src/main/java/org/kiwix/kiwixmobile/database/BookDao.java:44: error: cannot find symbol
public void setBookDetails(Book book, SquidCursor<BookDatabaseEntity> bookCursor) {
^
symbol: class BookDatabaseEntity
location: class BookDao
There was a problem hiding this comment.
@macgills could you do me a favour and once try if convert KiwixApplication to kotlin compiles for you, and if not what you would change in the build.gradle?
|
@soloturn In general this is recommended to have a ticket (bug report/feature request) explaining properly the what kind of thing the PR is about.... attached to the PR. PR without ticket has proven to be more complicated to deal with. |
|
This is made redundant by #1192. I f the aim is to convert KiwixApplication to kotlin then either attempt this on that branch or await it's merge to dev to reopen this. |
without this android-studio complains that it does not view DaggerApplicationComponent. not too sure though. i checked out and importet it.
Fix #1201