Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soloturn/kotlin #1202

Closed
wants to merge 2 commits into from
Closed

Soloturn/kotlin #1202

wants to merge 2 commits into from

Conversation

soloturn
Copy link
Contributor

should fix #1201 - but this is not it yet. it does not build successful. tried as well here: #1195.

@soloturn soloturn requested a review from macgills June 16, 2019 16:17
@macgills
Copy link
Contributor

I would wait for the merge of 2.5 to develop before we start using kotlin but I could be talked into it if there is a compelling reason. I will almost certainly have it merged by the end of the week

@soloturn
Copy link
Contributor Author

soloturn commented Jun 18, 2019

i am getting the same error here, as well as taking your kotlin branch in #1195, so yes, would be great if you could try once @macgills .

@macgills
Copy link
Contributor

After looking at the CI error I would say it is because you are not using kapt and instead are still using apt/annotationProcessor.
This is made redundant by #1192, seeing as how I can build 1192 and more importantly travis can build it (in addition to linting, running unit tests & running instrumentation tests) then the problem is on your end @soloturn. I will be closing this now.

@macgills macgills closed this Jun 19, 2019
@kelson42 kelson42 deleted the soloturn/kotlin branch June 23, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants