Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the hasFragileUserData tag in the manifest to display the "Keep app data" checkbox in the uninstall dialog. #4151

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4150

  • When users attempt to uninstall the app, the "Keep app data" checkbox will appear in the uninstall dialog. By enabling it, the app's data will not be deleted upon uninstallation, allowing users to access the data again if they reinstall the app. Additionally, this is a good way to notify users that uninstalling the app can delete all app-related data, such as ZIM files.

Image

@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft December 30, 2024 13:48
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.71%. Comparing base (b04375b) to head (64a1f3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4151      +/-   ##
============================================
- Coverage     56.74%   56.71%   -0.03%     
- Complexity     1526     1529       +3     
============================================
  Files           313      313              
  Lines         13367    13367              
  Branches       1655     1655              
============================================
- Hits           7585     7581       -4     
- Misses         4651     4660       +9     
+ Partials       1131     1126       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… app data" checkbox in the uninstall dialog.

* When users attempt to uninstall the app, the "Keep app data" checkbox will appear in the uninstall dialog. By enabling it, the app's data will not be deleted upon uninstallation, allowing users to access the data again if they reinstall the app. Additionally, this is a good way to notify users that uninstalling the app can delete all app-related data, such as ZIM files.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review December 31, 2024 05:53
@kelson42 kelson42 merged commit da8975a into main Jan 1, 2025
26 checks passed
@kelson42 kelson42 deleted the Fixes#4150 branch January 1, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If user uninstalled the application, then all the data(ZIM files) are also deleted.
3 participants