Merge pull request #811 from kiwix/lessRefresh

Only refresh library if some book has been added/removed in monitor dir
kiwix · Mar 5, 2022 · 243dd66 · 243dd66
2 parents 52a96cd + 2370019
commit 243dd66
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/library.cpp b/src/library.cpp
@@ -157,16 +157,19 @@ void Library::loadMonitorDir(QString monitorDir)
     QSet<QString> oldDir = QSet<QString>::fromList(oldDirEntries);
     QStringList addedZims = (newDir - oldDir).values();
     QStringList removedZims = (oldDir - newDir).values();
-    setMonitorDirZims(newDir.values());
     auto manipulator = LibraryManipulator(this);
     auto manager = kiwix::Manager(&manipulator);
+    bool needsRefresh = !removedZims.empty();
     for (auto book : addedZims) {
-        manager.addBookFromPath(book.toStdString());
+        needsRefresh |= manager.addBookFromPath(book.toStdString());
     }
     for (auto bookPath : removedZims) {
         removeBookFromLibraryById(QString::fromStdString(m_library.getBookByPath(bookPath.toStdString()).getId()));
     }
-    emit(booksChanged());
+    if (needsRefresh) {
+        setMonitorDirZims(newDir.values());
+        emit(booksChanged());
+    }
 }
 
 void Library::asyncLoadMonitorDir(QString dir)