Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only refresh library if some book has been added/removed in monitor dir #811

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

juuz0
Copy link
Collaborator

@juuz0 juuz0 commented Mar 3, 2022

This change leads to less refreshes if the monitor directory is same as download directory
Earlier, while downloading a file, it would send many refresh signals to file watcher leading to a bad user experience

Supersedes #803

src/library.cpp Outdated Show resolved Hide resolved
@juuz0
Copy link
Collaborator Author

juuz0 commented Mar 4, 2022

Don't merge yet please.

@juuz0
Copy link
Collaborator Author

juuz0 commented Mar 4, 2022

Done now ✅

src/library.cpp Outdated Show resolved Hide resolved
src/library.cpp Outdated Show resolved Hide resolved
@juuz0 juuz0 requested a review from mgautierfr March 4, 2022 19:40
@kelson42 kelson42 added this to the 2.3.0 milestone Mar 4, 2022
src/library.cpp Outdated Show resolved Hide resolved
This change leads to less refreshes if the monitor directory is same as download directory
Earlier, while downloading a file, it would send many refresh signals to file watcher leading to a bad user experience
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to continue to work properly

@kelson42 kelson42 merged commit 243dd66 into master Mar 5, 2022
@kelson42 kelson42 deleted the lessRefresh branch March 5, 2022 16:24
@kelson42 kelson42 modified the milestones: 2.3.0, 2.2.1 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants