Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the search button when the search box is empty sometimes fails to show all titles #1083

Closed
Jaifroid opened this issue Aug 31, 2023 · 4 comments · Fixed by #1237
Closed
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix user interface
Milestone

Comments

@Jaifroid
Copy link
Member

I believe this is due to a protection feature in the search, which prevents lookup if the same string is entered twice in a row (instead, it should just display the previous search). However, there is no previous search if the field is blank and the user has just loaded a ZIM.

I believe the solution is to exempt comparison of current search and prefix if the search box is empty / blank / null, and/or checking that we have search results to display before invoking the protection.

@Jaifroid Jaifroid added this to the v4.0 milestone Aug 31, 2023
@Jaifroid Jaifroid self-assigned this Aug 31, 2023
@Jaifroid Jaifroid modified the milestones: v4.0, v3.10 Sep 3, 2023
@Jaifroid Jaifroid added bug-non-critical For bugs that it would be nice to fix rather than critical to fix and removed bug labels Sep 5, 2023
@Jaifroid Jaifroid modified the milestones: v3.10, v4.0 Sep 10, 2023
@Jaifroid Jaifroid modified the milestones: v3.11, v4.0 Nov 1, 2023
@Jaifroid Jaifroid modified the milestones: v4.0, v4.1 Feb 21, 2024
@Jaifroid Jaifroid removed their assignment Mar 29, 2024
@Jaifroid
Copy link
Member Author

@dan-niles Thank you for addressing this issue! I'm assigning you.

@Jaifroid
Copy link
Member Author

I'm not sure why, but I can't seem to assign you. Anyway, this is confirmation that you are assigned.

@Jaifroid
Copy link
Member Author

@dan-niles Thank you for that PR. Just a word of friendly advice: before undertaking another PR (anywhere on Kiwix, not just here), it's always a good idea to ask to be assigned to the corresponding issue first. The reason is that there are some issues that are out-of-date or no longer wanted, but that we haven't closed. That's not the case for any of the PRs you've done here, I want to stress, but there is that slight risk, and I wouldn't want you to waste your time. Another reason is that if you comment on an issue, I think it is easier for the Repo maintainer to assign you to that issue. Thanks once again for you much-appreciated work.

@dan-niles
Copy link
Contributor

@Jaifroid Got it, thanks for the heads up! I'll be sure to ask to be assigned to corresponding issues before starting any future PRs. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants