Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for empty search box on initial ZIM load #1237

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Fix bug for empty search box on initial ZIM load #1237

merged 3 commits into from
Mar 31, 2024

Conversation

dan-niles
Copy link
Contributor

resolves #1083

I updated the protection check to exempt comparison of current search and prefix if the search box is empty.

@Jaifroid Jaifroid added user interface accessibility bug-non-critical For bugs that it would be nice to fix rather than critical to fix labels Mar 29, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Mar 29, 2024
@dan-niles
Copy link
Contributor Author

I made a mistake by removing the ! from the protection condtion that checks the status of the search. I was doing some testing and accidently committed it without changing it. Added it back in 5d74859.

@Jaifroid
Copy link
Member

I made a mistake by removing the ! from the protection condtion that checks the status of the search. I was doing some testing and accidently committed it without changing it. Added it back in 5d74859.

No problem. I'm just re-running tests.

Jaifroid
Jaifroid approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@Jaifroid Jaifroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this should fix the stated issue. Thank you! Let me know when you're Ok for me to squash-merge.

@dan-niles
Copy link
Contributor Author

Sure, you can go ahead and merge. 👍

@Jaifroid Jaifroid merged commit 8881e6a into kiwix:main Mar 31, 2024
6 checks passed
@dan-niles dan-niles deleted the fix-search-bug branch March 31, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaifroid Jaifroid Jaifroid approved these changes

Assignees

@dan-niles dan-niles

Labels
accessibility bug-non-critical For bugs that it would be nice to fix rather than critical to fix user interface
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

Clicking the search button when the search box is empty sometimes fails to show all titles
2 participants
@dan-niles @Jaifroid