You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pending the outcome of openzim/libzim#865, we may need to introduce a workaround in Kiwix JS readers.
See original issue for full detail, but the summary is that, on HTML pages that have been encoded by warc2zim2, querystrings are incorrectly presented with encoded separators (whereas those separators are not encoded in the ZIM URL). For example, index.html?thematique=internet might be presented as index.html%3Fthematique%3Dinternet. This currently causes KJS to fail, as it (correctly) does decodeURI() when converting the HTML representation to a ZIM URL, not decodeURIComponent().
If we decode the URI separators as well, then we could be left with anomalous situations like what_is_a_cookie?.html?title=What is a cookie?&theme=dark. So we will have to take care in such situations with how we handle the querystring.
The text was updated successfully, but these errors were encountered:
Pending the outcome of openzim/libzim#865, we may need to introduce a workaround in Kiwix JS readers.
See original issue for full detail, but the summary is that, on HTML pages that have been encoded by warc2zim2, querystrings are incorrectly presented with encoded separators (whereas those separators are not encoded in the ZIM URL). For example,
index.html?thematique=internet
might be presented asindex.html%3Fthematique%3Dinternet
. This currently causes KJS to fail, as it (correctly) doesdecodeURI()
when converting the HTML representation to a ZIM URL, notdecodeURIComponent()
.If we decode the URI separators as well, then we could be left with anomalous situations like
what_is_a_cookie?.html?title=What is a cookie?&theme=dark
. So we will have to take care in such situations with how we handle the querystring.The text was updated successfully, but these errors were encountered: