Workaround for over-encoded URLs in zimit2 #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
bug
backend
zimit
Zimit2 querystrings are currently over-encoded and included in the title. But this may not always be the case. See openzim/warc2zim#206.
|
Since further test ZIMs are not pending, we should merge and deal with any subsequent issues in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a workaround for over-encoded URLs in zimit2.
However, we could also usefully check to see that we are handling clicks on URLs in Wikipedia articles where an encoded question mark that is not a querystring needs to be decoded. For example, an HTML URL like
What_About_Me%3F_(Kenny_Rogers_album)needs to be decoded toA/What_About_Me?_(Kenny_Rogers_album)in order to find it in the ZIM and the material after the?must not be removed.Should fix #1229. Should only be merged pending the outcome of openzim/libzim#865.