Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy unused code for Evopedia and Cordova/Phonegap #226

Merged
merged 2 commits into from
May 10, 2017
Merged

Remove legacy unused code for Evopedia and Cordova/Phonegap #226

merged 2 commits into from
May 10, 2017

Conversation

mossroy
Copy link
Contributor

@mossroy mossroy commented May 6, 2017 •
edited
Loading

@sharun-s : this should help understanding the code for new contributors. See #218
It also simplifies a bit the UI and the understanding for the user.

@sharun-s
Copy link
Contributor

sharun-s commented May 7, 2017

@mossroy I will check it out. Don't worry I haven't given up. :-) Still working on those notes.

I am not a js dev so navigating all the anonymous functions, callbacks and async code can be quite crazy. It's not hard to understand what's going on, but it's hard to remember the flow of the code by the next day. And if I leave the code for a couple days full restart and review has to happen. Maybe this is just due to my lack of javascript experience. Anyway will keep you posted.

@mossroy mossroy force-pushed the remove-legacy-unused-code branch from c53bf4c to 191d093 Compare May 7, 2017 20:04
@mossroy
Drop Evopedia archive compatibility.
563090c 
And remove the corresponding legacy code.
And rename abstractBackend to zimArchiveLoader
Fixes #195
@mossroy
Remove Cordova/Phonegap code.
3001087 
Fixes #223
And rename osabstraction.js to abstractFilesystemAccess.js, to make its purpose more clear
@mossroy mossroy force-pushed the remove-legacy-unused-code branch from 191d093 to 3001087 Compare May 7, 2017 21:02
@mossroy
Copy link
Contributor Author

mossroy commented May 7, 2017

I also renamed 2 javascript files (abstractBackend and osabstraction) to try to make their purpose more clear

@mossroy mossroy merged commit c693362 into master May 10, 2017
@mossroy mossroy deleted the remove-legacy-unused-code branch May 10, 2017 12:43
@mossroy mossroy mentioned this pull request May 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossroy @sharun-s