Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more references to kiwix-read #569

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 25, 2022

Was removed in f9ce353.

@legoktm legoktm requested a review from veloman-yunkan July 25, 2022 20:45
@legoktm
Copy link
Member Author

legoktm commented Jul 25, 2022

The CI failures seem unrelated to my change?

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more references to kiwix-read are also present in

  • docker/README.md
  • format_code.sh

@legoktm legoktm force-pushed the rm-kiwix-search-man branch from aa15b1c to b6c6b75 Compare July 31, 2022 00:45
@legoktm
Copy link
Member Author

legoktm commented Jul 31, 2022

@veloman-yunkan done!

@kelson42 kelson42 force-pushed the rm-kiwix-search-man branch from b6c6b75 to 0df3c14 Compare July 31, 2022 07:43
@kelson42 kelson42 merged commit ce9e3e8 into master Jul 31, 2022
@kelson42 kelson42 deleted the rm-kiwix-search-man branch July 31, 2022 07:45
@kelson42 kelson42 added this to the 3.4.0 milestone Jul 31, 2022
mgautierfr added a commit that referenced this pull request Nov 30, 2022
 * Remove last reference to kiwix-read tool (@legoktm #569)

kiwix-serve
-----------

 * Fix broken indentation in usage (@kelson42 #560)
 * Exit if wrong arguments are passed (@kelson42 #567)
 * Do not allow multiple values for same option (@juuz0 #564)
 * Fix default location of "rootLocation" (@rgaudin #571)
 * [DOCKER] Change default port to 8080 (@neyder #581)
 * [DOCKER] Simplify dockerfile (@rgaudin #582)

kiwix-manage
------------

 * Fix man page (@kelson42 #576)
@mgautierfr mgautierfr mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants