Default kiwix-serve's rootLocation to "/" #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage mentions that the rootLocation defaults to `/` while it was not. It defaulted to an empty string. While it defaulting to "" or "/" has no technical consequence: libkiwix's server normalizes the requested rootLocation ; it leads to users setting a "/"-prefixed rootLocation when customizing it, resulting in double-slashed print of the URL to access kiwix-serve at. This harmonizes usage and actual default, fixing the URL print.
kelson42
requested review from
veloman-yunkan
and removed request for
mgautierfr
veloman-yunkan
requested changes
Jul 28, 2022
Reusing libkiwix's normalizeRootUrl() to display a more reliable representation of the rootLocation the InternalServer will be using. Can't reuse server.m_root as it is private.
You're right. I've copied the |
veloman-yunkan
approved these changes
Jul 28, 2022
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* Remove last reference to kiwix-read tool (@legoktm #569) kiwix-serve ----------- * Fix broken indentation in usage (@kelson42 #560) * Exit if wrong arguments are passed (@kelson42 #567) * Do not allow multiple values for same option (@juuz0 #564) * Fix default location of "rootLocation" (@rgaudin #571) * [DOCKER] Change default port to 8080 (@neyder #581) * [DOCKER] Simplify dockerfile (@rgaudin #582) kiwix-manage ------------ * Fix man page (@kelson42 #576)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage mentions that the
rootLocationdefaults to/while it was not. It defaulted to an empty string.While it defaulting to
""or"/"has no technical consequence: libkiwix's server normalizes the requested rootLocation ; it leads to users setting a"/"-prefixed rootLocation when customizing it, resulting in double-slashed print of the URLto access kiwix-serve at.
This harmonizes usage and actual default, fixing the URL print.