Fix public headers inclusion (+ small other fixes) #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 64.91% 64.92%
=======================================
Files 53 53
Lines 3737 3738 +1
Branches 1884 1881 -3
=======================================
+ Hits 2426 2427 +1
Misses 1309 1309
Partials 2 2
Continue to review full report at Codecov.
|
mgautierfr
force-pushed
the
remove_mustache_public_header
branch
3 times, most recently
from
bf5ae05 to
39a6308
Compare
kelson42
force-pushed
the
remove_mustache_public_header
branch
from
39a6308 to
d438890
Compare
veloman-yunkan
requested changes
Jul 1, 2021
mgautierfr
force-pushed
the
remove_mustache_public_header
branch
from
d438890 to
b65f065
Compare
maneeshpm
suggested changes
Jul 6, 2021
mgautierfr
force-pushed
the
remove_mustache_public_header
branch
from
b65f065 to
6cd50f6
Compare
|
Rebase on master (fixing the conflict (new archiveTools.h)). Fix last review comments of @maneeshpm |
maneeshpm
approved these changes
Jul 6, 2021
mgautierfr
force-pushed
the
remove_mustache_public_header
branch
from
6cd50f6 to
243406c
Compare
|
This branch needs to be rebased |
This by definition remove all the tool functions from the public API.
This header will contain our public tool functions.
- Add docstring - Move the declaration in kiwix namespace. - Adapt our include to include the right headers.
mgautierfr
force-pushed
the
remove_mustache_public_header
branch
from
243406c to
0b6b671
Compare
|
IMO we can merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #564
This also fix some declaration of
SuggestionItemmethods.On recent gcc, httplib raise warning and it break compilation with-WError.This PR include a patch for this. Upstream patch is here : yhirose/cpp-httplib#980
This has been removed from the PR as it fix a issue I've got only on my computer and the fix make macos compilation fail.