Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch httplib.h for gcc maybe-uninitialized warning. #575

Closed
wants to merge 1 commit into from

Conversation

mgautierfr
Copy link
Member

This is the removed commit from #574.

(Upstream issue : yhirose/cpp-httplib#980)

This patch is not compatible with macos.

Recent version of gcc warn about the use `buf` where it may be
uninitialized.
But here, buf is used as a output buffer to initialize it.

I'm not sure we can fix this differently than ignoring the warning.
@stale
Copy link

stale bot commented Jul 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 8, 2021
@kelson42
Copy link
Collaborator

@mgautierfr What shoukd we do with this PR?

@stale stale bot removed the stale label Jul 29, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Aug 18, 2021
@mgautierfr mgautierfr closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants