[pull] main from google:main #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Add missing package declaration on the AIDL interface slide. - Make the parcelable example more self-contained. The existing code was referencing variables that weren't declared in the example code. - Add a speaker note to the logging slide about explaining that the logger implementation is only needed in binaries, and that just the log facade is needed in libraries.
`thiserror` is best understood as a way to eliminate boilerplate on the patterns we've already seen, and then we can show it in conjunction with `anyhow` subsequently. Fixes #2027.
fa: Try to complete Farsi Part1 --------- Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com> Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
fa: Try to complete Farsi part2 --------- Co-authored-by: javad-jafari <javajafarifromsharak@gmail.com> Co-authored-by: javad-jafari <65780584+javad-jafari@users.noreply.github.com>
This avoids the hack for using aarch64-linux-gnu on Linux, and also removes a dependency. Also switched to using `cargo-objcopy`, as we require `cargo-binutils` already and it makes the Makefiles simpler.
Fixes #2379. This has `compile_fail` because `thiserror` isn't available from within `mdbook test`.
Part of #2478 to clean up code blocks when all that is needed is a trivial debug print statement. As mentioned in previous related PRs, in some places I've opted to retain the use of println! because dbg! makes it less readable. Co-authored-by: Eric Githinji <egithinji@google.com>
Dangling references are discussed later in the "Borrowing" segment. Fixes #2656
--------- Co-authored-by: Martin Geisler <mgeisler@google.com>
Part of #2478 to clean up code blocks when all that is needed is a trivial debug print statement. Co-authored-by: Eric Githinji <egithinji@google.com>
Fix typo in `es.po`. Arreglo de error ortográfico en `es.po`.
Inhaltsverzeichnis, Kurszeiten un Übersetzungen aktualisiert
Fixes bug #2004. Refactored the communication between the speaker notes window and the regular window by using a Broadcast channel - this is now self-recovering(!) even if speaker notes are closed and manually re-opened! For better readability and maintainability refactored some string-based states into enum style code and refactored detection of the type of windows (print, speaker note, regular window) Manually tested the new code and the speaker notes window does not disconnect from the regular window anymore. This now works way more reliable, even if there are (still) some UI glitches that have been there before already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )