feat: implement 0x1C - SHR opcode (#237)

* SHR * Use wrapping_shr * scarb fmt
kkrt-labs · Sep 1, 2023 · 61d1e41 · 61d1e41
1 parent 417ba5b
commit 61d1e41
Show file tree

Hide file tree

Showing 2 changed files with 431 additions and 1 deletion.
diff --git a/crates/evm/src/instructions/comparison_operations.cairo b/crates/evm/src/instructions/comparison_operations.cairo
@@ -128,7 +128,12 @@ impl ComparisonAndBitwiseOperations of ComparisonAndBitwiseOperationsTrait {
     /// 0x1C - SHR
     /// # Specification: https://www.evm.codes/#1c?fork=shanghai
     fn exec_shr(ref self: ExecutionContext) -> Result<(), EVMError> {
-        Result::Ok(())
+        let popped = self.stack.pop_n(2)?;
+        let shift = *popped[0];
+        let value = *popped[1];
+
+        let result = value.wrapping_shr(shift);
+        self.stack.push(result)
     }
 
     /// 0x1D - SAR